feat(optimizer): Fix qualify for SEMI/ANTI joins #4622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TobikoData/sqlmesh#3557
The RHS table of an SEMI/ANTI join shouldn't be collected as a selected source (in contrast to normal joins) since it's only used for the filtering process under the hood.
Note that as a side-effect of this, the
_expand_using
rule for SEMI/ANTI joins is turned off since we'd now fail to resolve the RHS related columns if they're expanded.PS: I believe a different solution would be to run
transforms.py::eliminate_semi_and_anti_joins
before the qualification step